Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Binepad BNK8 #36

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

silvinor
Copy link

@silvinor silvinor commented Dec 6, 2024

Description

Add the Binepad BNK8 macropad.

QMK Pull Request

Checklist

  • I have tested this keyboard definition with firmware on a device.(MANDATORY)
  • VIA keymap uses custom menus
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link

Cipulot commented Dec 6, 2024

@vinorodrigues when ready for review mark as ready and I'll get to it. Same for the other PR related to this board in the keyboards repo.

@silvinor silvinor marked this pull request as ready for review December 24, 2024 21:06
@Cipulot
Copy link

Cipulot commented Jan 1, 2025

@silvinor the json submitted here the-via/keyboards#2379 shows the usage of custom elements.
The code used to handle such behaviors must be included in this PR.

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Jan 1, 2025
silvinor added a commit to binepad-global/qmk_userspace_via that referenced this pull request Jan 1, 2025
@silvinor silvinor mentioned this pull request Jan 1, 2025
4 tasks
@silvinor
Copy link
Author

silvinor commented Jan 1, 2025

The code used to handle such behaviors must be included in this PR.

Ok - done. Code needed is in this PR, but I have also added the common code as #49 - as suggested by @Cipulot in Discord discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants